Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the signaling message handling in the
ConnectionBase
class by replacing hardcoded strings with constants. Additionally, it includes updates to the import statements and type definitions to support these changes.Refactoring for Signaling Messages:
packages/sdk/src/base.ts
: Replaced hardcoded signaling message types with constants such asSIGNALING_MESSAGE_TYPE_DISCONNECT
,SIGNALING_MESSAGE_TYPE_OFFER
, and others. This change improves code maintainability and reduces the risk of typos. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Constants and Types:
packages/sdk/src/constants.ts
: Added constants for signaling message types and roles, such asSIGNALING_MESSAGE_TYPE_OFFER
,SIGNALING_ROLE_SENDRECV
, and others. This centralizes the definitions and makes the code more readable and easier to update.packages/sdk/src/types.ts
: Updated type definitions to use the newly introduced constants, ensuring type safety and consistency across the codebase. [1] [2] [3]Import Statements:
packages/sdk/src/base.ts
: Updated import statements to include the newly defined constants and types, ensuring that all necessary dependencies are correctly imported. [1] [2]These changes collectively improve the maintainability, readability, and consistency of the codebase by centralizing the definitions of signaling message types and roles.